On Tue, Apr 23, 2013 at 06:30:50PM +0200, Arnd Bergmann wrote: > Both phy-tegra-usb.c and ehci-tegra.c export symbols used by the other one, > which does not work if one of them or both are loadable modules, resulting > in an error like: > > drivers/built-in.o: In function `utmi_phy_clk_disable': > drivers/usb/phy/phy-tegra-usb.c:302: undefined reference to > `tegra_ehci_set_phcd' > drivers/built-in.o: In function `utmi_phy_clk_enable': > drivers/usb/phy/phy-tegra-usb.c:324: undefined reference to > `tegra_ehci_set_phcd' > drivers/built-in.o: In function `utmi_phy_power_on': > drivers/usb/phy/phy-tegra-usb.c:447: undefined reference to > `tegra_ehci_set_pts' > > This turns the interface into a one-way dependency by letting the tegra ehci > driver pass two function pointers for callbacks that need to be called by > the phy driver. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Cc: Venu Byravarasu <vbyravar...@nvidia.com> > Cc: Alan Stern <st...@rowland.harvard.edu> > Cc: Felipe Balbi <ba...@ti.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Stephen Warren <swar...@nvidia.com> > Cc: linux-usb@vger.kernel.org > --- > drivers/usb/host/ehci-tegra.c | 10 +++++----- > drivers/usb/phy/tegra_usb_phy.c | 13 +++++++++---- > include/linux/usb/tegra_usb_phy.h | 10 +++++----- > 3 files changed, 19 insertions(+), 14 deletions(-)
Not all of these files are in my usb-next tree, so I can't take this patch, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
