Hi, I have sent two patches for the same issue, these two are merged into Greg's tree. Please review the patches.
[1] https://patchwork.kernel.org/patch/2599021 [2] https://patchwork.kernel.org/patch/2599031 Many thanks, Dongjin. On Sat, Jun 1, 2013 at 10:34 AM, Julius Werner <jwer...@chromium.org> wrote: > The usb3503 driver currently disables port 2 and 3 without explaination. > It doesn't make sense to do this in a mainline Linux driver that should > support all platforms which use this chip. If specific use cases really > require ports to be disabled, this should either be done through local > patches or a configurable mechanism (such as a device tree property). > Until then, let's keep all ports enabled. > > Signed-off-by: Julius Werner <jwer...@chromium.org> > --- > drivers/usb/misc/usb3503.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c > index 73aeb87..a647a2e 100644 > --- a/drivers/usb/misc/usb3503.c > +++ b/drivers/usb/misc/usb3503.c > @@ -134,14 +134,6 @@ static int usb3503_switch_mode(struct usb3503 *hub, enum > usb3503_mode mode) > goto err_hubmode; > } > > - /* PDS : Port2,3 Disable For Self Powered Operation */ > - err = usb3503_set_bits(i2c, USB3503_PDS, > - (USB3503_PORT2 | USB3503_PORT3)); > - if (err < 0) { > - dev_err(&i2c->dev, "PDS failed (%d)\n", err); > - goto err_hubmode; > - } > - > /* CFG1 : SELF_BUS_PWR -> Self-Powerd operation */ > err = usb3503_set_bits(i2c, USB3503_CFG1, > USB3503_SELF_BUS_PWR); > if (err < 0) { > -- > 1.7.12.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
