On Fri, 7 Jun 2013, Manjunath Goudar wrote:

> Separate the Samsung OHCI S3CXXXX host controller driver from ohci-hcd
> host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM.

> @@ -371,10 +384,9 @@ static int usb_hcd_s3c2410_probe(const struct hc_driver 
> *driver,
>               goto err_put;
>       }
>  
> +     ohci_setup(hcd);

Don't call ohci_setup().

> @@ -532,4 +480,36 @@ static struct platform_driver ohci_hcd_s3c2410_driver = {
>       },
>  };
>  
> +static int __init ohci_s3cxxxx_init(void)
> +{
> +     if (usb_disabled())
> +             return -ENODEV;
> +
> +     pr_info("%s: " DRIVER_DESC "\n", hcd_name);
> +     ohci_init_driver(&ohci_s3c2410_hc_driver, NULL);
> +
> +     /*
> +     * The Samsung HW has some unusual quirks, which require Sumsung-specific
> +     * workarounds. We override certain hc_driver functions here to
> +     * achieve that. We explicitly do not enhance ohci_driver_overrides to
> +     * allow this more easily, since this is an unusual case, and we don't
> +     * want to encourage others to override these functions by making it
> +     * too easy.
> +     */
> +
> +     ohci_s3c2410_hc_driver.hub_status_data  = ohci_s3c2410_hub_status_data;
> +     ohci_s3c2410_hc_driver.hub_control      = ohci_s3c2410_hub_control;

Like in ohci-at91, save the pointers before overwriting them.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to