On Thu, Jul 11, 2013 at 08:37:19AM +0200, Sascha Hauer wrote:
> >  
> > -   /* we only support host now, so enable vbus here */
> > -   data->reg_vbus = devm_regulator_get(&pdev->dev, "vbus");
> > -   if (!IS_ERR(data->reg_vbus)) {
> > -           ret = regulator_enable(data->reg_vbus);
> > -           if (ret) {
> > -                   dev_err(&pdev->dev,
> > -                           "Failed to enable vbus regulator, err=%d\n",
> > -                           ret);
> > -                   goto err_clk;
> > -           }
> > -   } else {
> > -           data->reg_vbus = NULL;
> > -   }
> > -
> >     pdata.phy = data->phy;
> >  
> > +   /* Get the vbus regulator */
> > +   pdata.reg_vbus = devm_regulator_get(&pdev->dev, "vbus");
> > +   if (IS_ERR(pdata.reg_vbus))
> > +           pdata.reg_vbus = NULL;
> 
> I think you should bail out at least in the -EPROBE_DEFER case.
> 

Oh, correct. I will add another patch behind this for fix.
In fact, I met this problem at FSL mx6-auto board which uses
gpio-expendor chip max7310 as regulator-gpio for enable vbus
output.

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to