On Thu, Aug 29, 2013 at 12:05 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Wed, 28 Aug 2013, Ming Lei wrote: > >> > Think about it this way: Why did you write the "USB: EHCI: improve >> > interrupt qh unlink" patch in the first place? Essentially the same >> > reason applies to uhci-hcd and ohci-hcd, and they will need similar >> > patches. >> >> Right, but drivers which submit URBs from tasklet/workque/... scheduled >> from complete() may need these patches too, even without giveback URB >> in complete() change. > > That's a totally separate issue. This email thread is about changes to > ehci-hcd, not bugs in other drivers. > > Drivers that submit isochronous URBs from tasklets/workqueues/whatever > without URB_ISO_ASAP are broken and need to be fixed. > >> You have said the same problem exists on these drivers already >> without giveback in tasklet patch, so for the problem and solution, >> there is no difference. > > What do you mean? We can't fix those other drivers by changing > ehci-hcd. It's their fault if they misuse the isochronous API.
OK, so submitting isoc URB has to be done from completion handler directly except for the start URBs, otherwise the usage violates isochronous API. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
