On Tue, Nov 05, 2013 at 03:22:53PM +0100, Stanislaw Wadas wrote: > mkdir() function is now performed after successful memory allocation > and gadget function creation. > Added inline to gadget_write_string(). > 256 hard coded value has been replaced by two defined > constants MAX_LENGTH and MAX_PATH_LENGTH
This is *much* better, thank you. Can you please split this into three logical changes? MAX_LENGTH, mkdir() move, and the inline change each should be in a separate patch. With that, this can be taken in. -Matt > Signed-off-by: Stanislaw Wadas <s.wa...@samsung.com> > --- > Changes since v1: > - fixed typos in MAX_LENGTH throughout > > include/gadget/gadget.h | 27 ++++++++------- > src/gadget.c | 84 > +++++++++++++++++++++++------------------------ > 2 files changed, 57 insertions(+), 54 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
