On Tue, Nov 12, 2013 at 02:51:47PM +0000, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" <iiva...@mm-sol.com> > > Allow support to use 2nd HSPHY with USB2 Core. > Some platforms may have configuration to allow USB controller > work with any of the two HSPHYs present. By default driver > configures USB core to use primary HSPHY. Add support to allow > user select 2nd HSPHY using DT parameter. > > Signed-off-by: Ivan T. Ivanov <iiva...@mm-sol.com> > Cc: Manu Gautam <mgau...@codeaurora.org> > Cc: devicet...@vger.kernel.org > --- > .../devicetree/bindings/usb/msm-hsusb.txt | 6 +++++ > drivers/usb/phy/phy-msm-usb.c | 24 > ++++++++++++++++++-- > include/linux/usb/msm_hsusb.h | 1 + > include/linux/usb/msm_hsusb_hw.h | 1 + > 4 files changed, 30 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt > b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > index 3f21204..d105ba9 100644 > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > @@ -72,6 +72,12 @@ Optional properties: > - qcom,phy-init-sequence: PHY configuration sequence. val, reg pairs > terminate with -1 > > +- qcom,phy-num: Select number of pyco-phy to use, can be one of > + 0 - PHY one, default > + 1 - Second PHY > + Some platforms may have configuration to allow > USB > + controller work with any of the two HSPHYs > present. > +
Only one can be used at a time? [...] > @@ -1395,6 +1412,9 @@ static int msm_otg_read_dt(struct platform_device > *pdev, struct msm_otg *motg) > if (!of_property_read_u32(node, "qcom,otg-control", &val)) > pdata->otg_control = val; > > + if (!of_property_read_u32(node, "qcom,phy-num", &val)) > + motg->phy_number = val; No sanity checking? If not all of your tests on the value of motg->phy_number are the same form, you may get undepected results... Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
