Re: [PATCH v3 2/2] usb: phy: Add keystone usb phy driver

[Felipe Balbi]

Hi,

On Mon, Dec 09, 2013 at 05:17:04PM -0500, WingMan Kwok wrote:
> +     ret = usb_add_phy_dev(&k_phy->usb_phy_gen.phy);
> +     if (ret)
> +             return ret;
> +     k_phy->usb_phy_gen.phy.init = keystone_usbphy_init;
> +     k_phy->usb_phy_gen.phy.shutdown = keystone_usbphy_shutdown;

this *must* be initialized before adding the PHY to the subsystem. So
these two lines must be moved before usb_add_phy_dev().

-- 
balbi

signature.asc
Description: Digital signature