phy-tahvo introduced the following smatch warnings:
drivers/usb/phy/phy-tahvo.c:203 tahvo_usb_set_host() warn: variable
dereferenced before check 'otg' (see line 199)
drivers/usb/phy/phy-tahvo.c:235 tahvo_usb_set_peripheral() warn: variable
dereferenced before check 'otg' (see line 231)
Fix by deleting bogus NULL pointer checks. The USB framework will always
call us with a valid OTG pointer.
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi>
---
drivers/usb/phy/phy-tahvo.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index 8bb833e22d64..cc61ee44b911 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -200,9 +200,6 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct
usb_bus *host)
dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host);
- if (otg == NULL)
- return -ENODEV;
-
mutex_lock(&tu->serialize);
if (host == NULL) {
@@ -232,9 +229,6 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg,
dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget);
- if (!otg)
- return -ENODEV;
-
mutex_lock(&tu->serialize);
if (!gadget) {
--
1.8.5.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
