Hi,
On 01/21/2014 06:59 PM, Sergei Shtylyov wrote:
Hello.
On 01/15/2014 10:24 PM, Hans de Goede wrote:
Add support for ohci-platform instantiation from devicetree, including
optionally getting clks and a phy from devicetree, and enabling / disabling
those on power_on / off.
This should allow using ohci-platform from devicetree in various cases.
Specifically after this commit it can be used for the ohci controller found
on Allwinner sunxi SoCs.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
Acked-by: Alan Stern <st...@rowland.harvard.edu>
[...]
Have only found time to fully read the patches just now...
diff --git a/Documentation/devicetree/bindings/usb/usb-ohci.txt
b/Documentation/devicetree/bindings/usb/usb-ohci.txt
new file mode 100644
index 0000000..f9d6c73
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/usb-ohci.txt
@@ -0,0 +1,22 @@
+USB OHCI controllers
+
+Required properties:
+- compatible : "usb-ohci"
+- reg : ohci controller register range (address and length)
+- interrupts : ohci controller interrupt
+
+Optional properties:
+- clocks : a list of phandle + clock specifier pairs
+- phys : phandle + phy specifier pair
+- phy-names : "usb"
+
+Example:
+
+ ohci0: ohci@0x01c14400 {
Two minor nits: there should be no "0x" in the address part of the node name.
And according to ePAPR [1], "the name of a node should be somewhat generic, reflecting
the function of the device and not its precise programming model. If appropriate, the name
should be one of the following choices:
[...]
- usb".
Same comments for "usb-ehci" binding.
You're right on both accounts, I'll do a v8 tomorrow, including a re-spin of the
big-endian patches.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
