On 02/21/2014 10:40 AM, Peter Chen wrote: > >>> >>> Required properties: >>> -- compatible: Should be "fsl,imx23-usbphy" >>> +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q- >> usbphy" >>> + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl >> >> Minor nit, but could we restructure this as something like the following, >> with each string on a new line: >> >> - compatible: should contain: >> * "fsl,imx23-usbphy" for imx23 and imx28 >> * "fsl,imx6q-usbphy" for imx6dq and imx6dl >> * "fsl,imx6sl-usbphy" for imx6sl >> >> It makes it a bit easier to read. > > Thanks, will change like above. > >> >> I see the existing "fsl,imx23-usbphy" is used as a fallback for >> "fsl,imx28-usbphy", "fsl,imx6q-usbphy", and "fsl,imx6sl-usbphy" in >> existing DTs. >> >> Is this expected going forward? It might be worth mentioning. >> > > These SoCs used the same FSL imx PHY, but different versions. > imx23/imx28 are the first version, more improvements are at > later SoCs (like imx6x) version. Keep "fsl,imx23-usbphy" at > imx6 dts will be user know it is from imx23's. If you think > it does not need, I can delete "fsl,imx23-usbphy" from imx6 dts.
You should go after compatibility here. List (all) phys that are comaptible, start with most specific end with most generic. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature