Re: [PATCH v6 part1 5/8] usb: assign usb3 external hub port peers

[Dan Williams]

On Mon, 2014-03-03 at 18:33 -0800, Dan Williams wrote:
> Subject: usb: assign usb3 external hub port peers
> 
> From: Dan Williams <dan.j.willi...@intel.com>
> 
> Given that root hub port peers are already established, external hub peer
> ports can be determined by traversing the device topology:
> 
> 1/ ascend to the parent hub and find the upstream port_dev
> 
> 2/ walk ->peer to find the peer port
> 
> 3/ descend to the peer hub via ->child
> 
> 4/ find the port with the matching port id
> 
> Note that this assumes the port labeling scheme required by the
> specification [1].
> 
> [1]: usb3 3.1 section 10.3.3
> 
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>

Just rebase to handle the find_and_link_peer() rename.

8<-------
Subject: usb: assign usb3 external hub port peers

From: Dan Williams <dan.j.willi...@intel.com>

Given that root hub port peers are already established, external hub peer
ports can be determined by traversing the device topology:

1/ ascend to the parent hub and find the upstream port_dev

2/ walk ->peer to find the peer port

3/ descend to the peer hub via ->child

4/ find the port with the matching port id

Note that this assumes the port labeling scheme required by the
specification [1].

[1]: usb3 3.1 section 10.3.3

Signed-off-by: Dan Williams <dan.j.willi...@intel.com>
---
 drivers/usb/core/port.c |   32 ++++++++++++++++++++++++--------
 1 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
index 0d36610af156..fd53257de6a9 100644
--- a/drivers/usb/core/port.c
+++ b/drivers/usb/core/port.c
@@ -181,15 +181,18 @@ static void unlink_peers(struct usb_port *left, struct 
usb_port *right)
        left->peer = NULL;
 }
 
-/* set the default peer port for root hubs */
+/*
+ * Set the default peer port for root hubs, or via the upstream peer
+ * relationship for all other hubs
+ */
 static void find_and_link_peer(struct usb_hub *hub, int port1)
 {
        struct usb_port *port_dev = hub->ports[port1 - 1], *peer;
        struct usb_device *hdev = hub->hdev;
+       struct usb_device *peer_hdev;
+       struct usb_hub *peer_hub;
 
        if (!hdev->parent) {
-               struct usb_hub *peer_hub;
-               struct usb_device *peer_hdev;
                struct usb_hcd *hcd = bus_to_hcd(hdev->bus);
                struct usb_hcd *peer_hcd = hcd->shared_hcd;
 
@@ -197,15 +200,28 @@ static void find_and_link_peer(struct usb_hub *hub, int 
port1)
                        return;
 
                peer_hdev = peer_hcd->self.root_hub;
-               peer_hub = usb_hub_to_struct_hub(peer_hdev);
-               if (!peer_hub || port1 > peer_hdev->maxchild)
+       } else {
+               struct usb_port *upstream;
+               struct usb_device *parent = hdev->parent;
+               struct usb_hub *parent_hub = usb_hub_to_struct_hub(parent);
+
+               if (!parent_hub)
                        return;
 
-               peer = peer_hub->ports[port1 - 1];
+               upstream = parent_hub->ports[hdev->portnum - 1];
+               if (!upstream || !upstream->peer)
+                       return;
 
-               if (peer)
-                       link_peers(port_dev, peer);
+               peer_hdev = upstream->peer->child;
        }
+
+       peer_hub = usb_hub_to_struct_hub(peer_hdev);
+       if (!peer_hub || port1 > peer_hdev->maxchild)
+               return;
+
+       peer = peer_hub->ports[port1 - 1];
+       if (peer)
+               link_peers(port_dev, peer);
 }
 
 int usb_hub_create_port_device(struct usb_hub *hub, int port1)


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html