From: Hans de Goede <hdego...@redhat.com>

I thought it would be a good idea to also test uas with usb-2, and it turns out
it was, as it did not work. The problem is that the uas driver was passing the
bEndpointAddress' direction bit to usb_rcvbulkpipe, the xhci code seems to not
care about this, but with the ehci code this causes usb_submit_urb failure.

With this fixed the uas code works nicely with an uas device plugged into
an ehci port.

Signed-off-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: Sarah Sharp <sarah.a.sh...@linux.intel.com>
---
 drivers/usb/storage/uas.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 5eacb8054457..6ad5de9639d5 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -948,13 +948,13 @@ static void uas_configure_endpoints(struct uas_dev_info 
*devinfo)
                eps[3] = usb_pipe_endpoint(udev, devinfo->data_out_pipe);
        } else {
                devinfo->cmd_pipe = usb_sndbulkpipe(udev,
-                                               eps[0]->desc.bEndpointAddress);
+                                            usb_endpoint_num(&eps[0]->desc));
                devinfo->status_pipe = usb_rcvbulkpipe(udev,
-                                               eps[1]->desc.bEndpointAddress);
+                                            usb_endpoint_num(&eps[1]->desc));
                devinfo->data_in_pipe = usb_rcvbulkpipe(udev,
-                                               eps[2]->desc.bEndpointAddress);
+                                            usb_endpoint_num(&eps[2]->desc));
                devinfo->data_out_pipe = usb_sndbulkpipe(udev,
-                                               eps[3]->desc.bEndpointAddress);
+                                            usb_endpoint_num(&eps[3]->desc));
        }
 
        devinfo->qdepth = usb_alloc_streams(devinfo->intf, eps + 1, 3, 256,
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to