Hi Mathias,
On Wed, Aug 13, 2014 at 03:12:25PM +0300, Mathias Nyman wrote:
> On 08/12/2014 05:13 PM, Huang Rui wrote:
> > AMD xHC also needs short tx quirk after tested on most of chipset
> > generations. That's because there is the same incorrect behavior like
> > Fresco Logic host. Please see below message with on USB webcam
> > attached on xHC host:
> >
> > [ 139.262944] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.266934] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.270913] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.274937] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.278914] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.282936] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.286915] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.290938] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.294913] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> > [ 139.298917] xhci_hcd 0000:00:10.0: WARN Successful completion on short
> > TX: needs XHCI_TRUST_TX_LENGTH quirk?
> >
> > Reported-by: Arindam Nath <arindam.n...@amd.com>
> > Tested-by: Shriraj-Rai P <shriraj-ra...@amd.com>
> > Cc: <sta...@vger.kernel.org>
> > Signed-off-by: Huang Rui <ray.hu...@amd.com>
> > ---
> > drivers/usb/host/xhci-pci.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index e20520f..399a222 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -101,6 +101,10 @@ static void xhci_pci_quirks(struct device *dev, struct
> > xhci_hcd *xhci)
> > /* AMD PLL quirk */
> > if (pdev->vendor == PCI_VENDOR_ID_AMD && usb_amd_find_chipset_info())
> > xhci->quirks |= XHCI_AMD_PLL_FIX;
> > +
> > + if (pdev->vendor == PCI_VENDOR_ID_AMD)
> > + xhci->quirks |= XHCI_TRUST_TX_LENGTH;
> > +
> > if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
> > xhci->quirks |= XHCI_LPM_SUPPORT;
> > xhci->quirks |= XHCI_INTEL_HOST;
> >
>
> Thanks, I got a report that the AMD FCH hosts needed this quirk earlier, and
> have a patch pending for those.
>
> I'll use this instead
>
Thanks a lot. When you encountered AMD FCH issues in future, please
add me :)
Thanks,
Rui
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
