Francois Romieu [mailto:rom...@fr.zoreil.com] 
[...]
> > +static void rtl_request_firmware(struct r8152 *tp)
> > +{
> > +   char *fw_name = NULL;
> > +
> > +   if (tp->rtl_fw.fw)
> > +           goto out_request;
> > +
> > +   switch (tp->version) {
> > +   case RTL_VER_01:
> > +           fw_name = "rtl_nic/rtl8152-1.fw";
> > +           break;
> > +   case RTL_VER_02:
> > +           fw_name = "rtl_nic/rtl8152-2.fw";
> > +           break;
> > +   case RTL_VER_03:
> > +           fw_name = "rtl_nic/rtl8153-1.fw";
> > +           break;
> > +   case RTL_VER_04:
> > +           fw_name = "rtl_nic/rtl8153-2.fw";
> > +           break;
> > +   case RTL_VER_05:
> > +           fw_name = "rtl_nic/rtl8153-3.fw";
> > +           break;
> 
> The driver should use MODULE_FIRMWARE() for these files.

Oops. I would fix this. Thanks.
 
Best Regards,
Hayes
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to