On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote:
> On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
> > On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
> > > As always, comments are welcome.
> >
> > Are nits welcome too?
> >
> > > +MODULE_LICENSE("GPLv2");
> >
> > You probably meant
> > MODULE_LICENSE("GPL v2")
> >
> > Didn't that trigger a warning or error?
>
> checkpatch showed no warning about that, not even with --strict option.
> I believe both ways are fine. But I can add the space.
"GPLv2" is not mentioned in include/linux/license.h so, as I remember,
it would taint the kernel, and a warning will be printed when you load
that module.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
