On Fri, 2015-03-20 at 15:02 +0100, Bjørn Mork wrote:
> Oliver Neukum <oneu...@suse.de> writes:
>
> > This makes sure the error handling path is the same for
> > all error conditions, thus reducing code duplication.
>
> Great! This looks like I nice cleanup. Will test it out. Just a quick
> comment based on the first glance:
>
> > outnl:
> > return rv < 0 ? rv : count;
>
> How about changing the single remaining error without any rewinding into
> a direct "return -ENOMEM", and then drop the "outnl" label and simplify
> this to "return count"?
That would be the direct opposite of what this patch tries to do.
Direct returns in a function with lock are not what I prefer to do.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
