Hi,

On Tue, Mar 24, 2015 at 10:01:06AM +0100, Mian Yousaf Kaukab wrote:
> diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c
> index 63207dc..3735ae6 100644
> --- a/drivers/usb/dwc2/hcd_queue.c
> +++ b/drivers/usb/dwc2/hcd_queue.c
> @@ -231,9 +231,10 @@ void dwc2_hcd_qh_free(struct dwc2_hsotg *hsotg, struct 
> dwc2_qh *qh)
>  {
>       if (hsotg->core_params->dma_desc_enable > 0)
>               dwc2_hcd_qh_free_ddma(hsotg, qh);
> -     else if (qh->dw_align_buf)
> -             dma_free_coherent(hsotg->dev, qh->dw_align_buf_size,
> -                               qh->dw_align_buf, qh->dw_align_buf_dma);
> +     else if (qh->dw_align_buf) {
> +             kfree(qh->dw_align_buf);
> +             qh->dw_align_buf_dma = (dma_addr_t)0;
> +     }

kfree(NULL) is safe. This could be:

else {
        kfree....;
        qh->dw....;
}

>       kfree(qh);
>  }
>  
> -- 
> 2.3.3
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature

Reply via email to