> -----Original Message-----
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, September 30, 2015 6:26 PM
> To: Sergei Shtylyov
> Cc: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com;
> john.y...@synopsys.com; Herrero, Gregory; he...@sntech.de;
> diand...@chromium.org; r.bald...@samsung.com;
> dingu...@opensource.altera.com; zhangfei....@linaro.org;
> david.a.co...@linux.intel.com
> Subject: Re: [PATCH v3 20/32] usb: dwc2: force dr_mode in case of
> configuration mismatch
> 
> On Tue, Sep 29, 2015 at 09:58:56PM +0300, Sergei Shtylyov wrote:
> > On 09/29/2015 01:08 PM, Mian Yousaf Kaukab wrote:
> >
> > >If dual role configuration is not selected, check and force dr_mode
> > >based on the selected configuration.
> > >
> > >Signed-off-by: Mian Yousaf Kaukab <yousaf.kau...@intel.com>
> > >Tested-by: Robert Baldyga <r.bald...@samsung.com>
> > >Tested-by: Dinh Nguyen <dingu...@opensource.altera.com>
> > >Tested-by: John Youn <johny...@synopsys.com>
> > >Acked-by: John Youn <johny...@synopsys.com>
> > >---
> > >  drivers/usb/dwc2/platform.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > >diff --git a/drivers/usb/dwc2/platform.c
> > >b/drivers/usb/dwc2/platform.c index ed7a78e..0945e21 100644
> > >--- a/drivers/usb/dwc2/platform.c
> > >+++ b/drivers/usb/dwc2/platform.c
> > >@@ -368,6 +368,17 @@ static int dwc2_driver_probe(struct
> platform_device *dev)
> > >           (unsigned long)res->start, hsotg->regs);
> > >
> > >   hsotg->dr_mode = usb_get_dr_mode(&dev->dev);
> > >+  if (IS_ENABLED(CONFIG_USB_DWC2_HOST) &&
> > >+          hsotg->dr_mode != USB_DR_MODE_HOST) {
> >
> >    Please indent with 2 tabs, so that it's easier on the eyes, not
> > blending with the following...
> 
> fixed both myself
> 
Thank you for taking care of this!

> --
> balbi

BR,
Yousaf
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to