On 06/06/2016 11:23 PM, Sudip Mukherjee wrote: > The only caller of get_gadget_descs() has already dereferenced udc > before calling this function, so udc can not be NULL at this point of > the code and hence no use of checking it. > > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> > --- > drivers/usb/usbip/vudc_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c > index 99397fa..0f98f2c 100644 > --- a/drivers/usb/usbip/vudc_sysfs.c > +++ b/drivers/usb/usbip/vudc_sysfs.c > @@ -40,7 +40,7 @@ int get_gadget_descs(struct vudc *udc) > struct usb_ctrlrequest req; > int ret; > > - if (!udc || !udc->driver || !udc->pullup) > + if (!udc->driver || !udc->pullup) > return -EINVAL; > > req.bRequestType = USB_DIR_IN | USB_TYPE_STANDARD | USB_RECIP_DEVICE; >
Reviewed-by: Krzysztof Opasiak <k.opas...@samsung.com> -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
