On Tue, Jul 26 2016, Felipe F. Tonello wrote:
> Use gadget's framework allocation function instead of directly calling
> usb_ep_alloc_request().
>
> Signed-off-by: Felipe F. Tonello <e...@felipetonello.com>

Acked-by: Michal Nazarewicz <min...@mina86.com>

> ---
>  drivers/usb/gadget/function/f_hid.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_hid.c 
> b/drivers/usb/gadget/function/f_hid.c
> index a010496e4e05..89d2e9a5a04f 100644
> --- a/drivers/usb/gadget/function/f_hid.c
> +++ b/drivers/usb/gadget/function/f_hid.c
> @@ -611,14 +611,10 @@ static int hidg_bind(struct usb_configuration *c, 
> struct usb_function *f)
>  
>       /* preallocate request and buffer */
>       status = -ENOMEM;
> -     hidg->req = usb_ep_alloc_request(hidg->in_ep, GFP_KERNEL);
> +     hidg->req = alloc_ep_req(hidg->in_ep, hidg->report_length);
>       if (!hidg->req)
>               goto fail;
>  
> -     hidg->req->buf = kmalloc(hidg->report_length, GFP_KERNEL);
> -     if (!hidg->req->buf)
> -             goto fail;
> -
>       /* set descriptor dynamic values */
>       hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
>       hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
> -- 
> 2.9.0
>

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to