On Tue, Nov 01, 2016 at 04:31:07PM +0200, Felipe Balbi wrote:
> 
> Hi Greg,
> 
> Here's another set of fixes for current -rc cycle. Let me know if you
> want anything to be changed.
> 
> cheers
> 
> The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30:
> 
>   Linux 4.9-rc3 (2016-10-29 13:52:02 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git 
> tags/fixes-for-v4.9-rc4
> 
> for you to fetch changes up to fd9afd3cbe404998d732be6cc798f749597c5114:
> 
>   usb: gadget: u_ether: remove interrupt throttling (2016-11-01 15:48:25 
> +0200)
> 
> ----------------------------------------------------------------
> usb: fixes for v4.9-rc4
> 
> Three more fixes for current -rc cycle. One
> randbuild fix on dwc3-st which was lacking
> <linux/pinctrl/consumer.h>, removal of IRQ
> throttling for networking gadgets and a fix for
> dwc3's error handling on failed initialization.
> 
> ----------------------------------------------------------------
> Felipe Balbi (2):
>       usb: dwc3: st: add missing <linux/pinctrl/consumer.h> include
>       usb: gadget: u_ether: remove interrupt throttling
> 
> Vivek Gautam (1):
>       usb: dwc3: Fix error handling for core init
> 
>  drivers/usb/dwc3/core.c               | 5 ++---
>  drivers/usb/dwc3/dwc3-st.c            | 1 +
>  drivers/usb/gadget/function/u_ether.c | 8 --------
>  3 files changed, 3 insertions(+), 11 deletions(-)
> 

Hi Felipe,

I just notice that you submitted the "usb: gadget: u_ether: remove
interrupt throttling", and cc stable tree too, but we can't get
the agreement that it is suitable for all USB controllers, and David
added this comment later that the networking stack has no hard
requirement (eg, half of second) [1] which is not the same at your
commit log.

We have this tx interrupt throttling feature from this driver has been
written (at year 2008), and millions of shipped devices have this
feature. Even you think this feature really has problem, you may add
this to -next tree first, and test one or two revisions, this feature
itself is not a bug in all, just some controllers may can't use it.

[1] https://www.spinics.net/lists/linux-usb/msg148762.html

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to