On Tue, Nov 15, 2016 at 03:03:40PM -0800, John Youn wrote: > From: Christian Lamparter <chunk...@googlemail.com> > > This patch adds support for the "amcc,usb-otg" device > which is found in the PowerPC Canyonlands' dts. > > The device definition was added by: > > commit c89b3458d8cc ("powerpc/44x: Add USB DWC DTS entry to Canyonlands > board") > > but without any driver support as the dwc2 driver wasn't available at > that time. > > Note: The system can't use the generic "snps,dwc2" compatible > because of the special ahbcfg configuration. The default > GAHBCFG_HBSTLEN_INCR4 of snps,dwc2 can cause a system hang > when the USB and SATA is used concurrently. > > Signed-off-by: Christian Lamparter <chunk...@gmail.com> > Signed-off-by: John Youn <johny...@synopsys.com> > --- > > Sorry, the previous one broke compilation. This fixes it. > > Regards, > John > > v3 [johnyoun]: > * Fixed compilation issue > > v2 [johnyoun]: > * Removed params struct > * Minor commit message formatting > > Documentation/devicetree/bindings/usb/dwc2.txt | 1 + > drivers/usb/dwc2/params.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt > b/Documentation/devicetree/bindings/usb/dwc2.txt > index ad8f7ff..6c7c2bce 100644 > --- a/Documentation/devicetree/bindings/usb/dwc2.txt > +++ b/Documentation/devicetree/bindings/usb/dwc2.txt > @@ -12,6 +12,7 @@ Required properties: > - "lantiq,xrx200-usb": The DWC2 USB controller instance in Lantiq XRX SoCs; > - "amlogic,meson8b-usb": The DWC2 USB controller instance in Amlogic > Meson8b SoCs; > - "amlogic,meson-gxbb-usb": The DWC2 USB controller instance in Amlogic > S905 SoCs; > + - "amcc,dwc-otg": The DWC2 USB controller instance in AMCC Canyonlands > 460EX SoCs; > - snps,dwc2: A generic DWC2 USB controller with default parameters. > - reg : Should contain 1 register range (address and length) > - interrupts : Should contain 1 interrupt > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index 513556a..a786256 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -239,6 +239,7 @@ const struct of_device_id dwc2_of_match_table[] = { > { .compatible = "samsung,s3c6400-hsotg", .data = NULL}, > { .compatible = "amlogic,meson8b-usb", .data = ¶ms_amlogic }, > { .compatible = "amlogic,meson-gxbb-usb", .data = ¶ms_amlogic }, > + { .compatible = "amcc,dwc-otg", .data = NULL },
'.data = NULL' is unnecessary. With that fixed, Acked-by: Rob Herring <r...@kernel.org> > {}, > }; > MODULE_DEVICE_TABLE(of, dwc2_of_match_table); > -- > 2.10.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html