On Mon, 26 Dec 2016, Linus Torvalds wrote:

> On Dec 26, 2016 4:04 PM, "Alan Stern" wrote:
> 
> 
> Note that the usage of tmp in the "if (unlikely(req->td->dmadesc == 0)) {"
> branch really is not conflicting, because that branch breaks out of the
> enclosing "while" loop.
> 
> 
> No.
> 
> Look closer.
> 
> It does indeed breast out of the loop, but before it dies that, it uses
> "tmp" again. And it wants the *old* tmp, not the new one..

Are you certain that it doesn't want the new value of tmp?  How can you
tell? -- it was not immediately obvious to me.  This was what I had in
mind when I wrote that it wasn't clear whether your patch was entirely
correct.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to