On 1/17/2017 12:51 PM, Heiner Kallweit wrote:
> Commit 9962b62f1be9 "Deprecate g-use-dma binding" removed the only
> property in dwc2_pci_quirks. This function is dead code now.
>
> Maybe it was kept intentionally to be prepared for the case that
> another quirk-related property needs to be added in future.
> If not it can be removed.
>
> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
> ---
> drivers/usb/dwc2/pci.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
> index a23329e3..ae419615 100644
> --- a/drivers/usb/dwc2/pci.c
> +++ b/drivers/usb/dwc2/pci.c
> @@ -62,20 +62,6 @@ struct dwc2_pci_glue {
> struct platform_device *phy;
> };
>
> -static int dwc2_pci_quirks(struct pci_dev *pdev, struct platform_device
> *dwc2)
> -{
> - if (pdev->vendor == PCI_VENDOR_ID_SYNOPSYS &&
> - pdev->device == PCI_PRODUCT_ID_HAPS_HSOTG) {
> - struct property_entry properties[] = {
> - { },
> - };
> -
> - return platform_device_add_properties(dwc2, properties);
> - }
> -
> - return 0;
> -}
> -
> static void dwc2_pci_remove(struct pci_dev *pci)
> {
> struct dwc2_pci_glue *glue = pci_get_drvdata(pci);
> @@ -136,10 +122,6 @@ static int dwc2_pci_probe(struct pci_dev *pci,
> return PTR_ERR(phy);
> }
>
> - ret = dwc2_pci_quirks(pci, dwc2);
> - if (ret)
> - goto err;
> -
> ret = platform_device_add(dwc2);
> if (ret) {
> dev_err(dev, "failed to register dwc2 device\n");
>
I'd like to leave this in place for now.
We still have stuff in here internally and we have some enhancements
in the works to support IP validation, which will need to set
properties from here.
Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
