On 1/30/2017 11:13 PM, Heiner Kallweit wrote: > Am 31.01.2017 um 03:32 schrieb John Youn: >> On 1/28/2017 2:06 PM, Heiner Kallweit wrote: >>> Supplies for vusb_a and vusb_d are needed only on a minority of systems >>> supported by the dwc2 driver (AFAIK systems with Samsung SoCs). >>> >>> On all other systems this results in these harmless but annoying >>> warnings: >>> >>> c9000000.usb supply vusb_d not found, using dummy regulator >>> c9000000.usb supply vusb_a not found, using dummy regulator >>> >>> Introduce a configuration parameter to ignore the supplies on >>> systems not needing it. >> >> You can probably just check for the existence of those bindings. Or >> possibly use devm_regulator_get_optional(). >> > Right, that we could do to silence the warning. But then we would > loose the warning on systems where these supplies are mandatory > (in case somebody adds a system with such a SoC and forgets to define > the supplies in the DT).
I don't think the dwc2 driver should be doing that though. It should treat these as optional properties and use them if available, just like it does now for the reset control, phy, clocks, etc. Otherwise you could make the case for adding the same flag for these other components as well. But really, I just don't want to add new parameters, if anything I want to remove more of them. Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
