On Fri, May 26, 2017 at 06:30:38AM -0700, Guenter Roeck wrote:
> On 05/26/2017 04:08 AM, Heikki Krogerus wrote:
> > Hi,
> > 
> > On Thu, May 25, 2017 at 06:23:30AM -0700, Guenter Roeck wrote:
> > > > +       /*
> > > > +        * NOTE: The memory region for the data structures is used also 
> > > > in an
> > > > +        * operation region, which means ACPI has already reserved it. 
> > > > Therefore
> > > > +        * it can not be requested here.
> > > > +        */
> > > > +       ua->ppm.data = devm_ioremap(&pdev->dev, res->start, 
> > > > resource_size(res));
> > > 
> > > devm_ioremap_resource() ?
> > 
> > devm_ioremap_resource() will try to request the region, and like I
> > tried to explain in the comment, it will fail as the region has
> > already been reserved by ACPI.
> > 
> 
> Maybe add this to the comment above ?
> 
>   .. it can not be requested here, and we can not use devm_ioremap_resource().

OK.

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to