On Wed, 11 Oct 2017 16:33:37 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 12:36:43PM +0200, Takashi Iwai wrote: > > usx2y driver sets up URBs containing the fixed endpoints without > > validation. This may end up with an oops-like kernel warning when > > submitted. > > > > For avoiding it, this patch adds the calls of the new sanity-check > > helper for URBs. > > > > Signed-off-by: Takashi Iwai <ti...@suse.de> > > --- > > sound/usb/usx2y/usbusx2y.c | 8 ++++++++ > > sound/usb/usx2y/usbusx2yaudio.c | 3 +++ > > 2 files changed, 11 insertions(+) > > > > diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c > > index 4569c0efac0a..55a631ccfa25 100644 > > --- a/sound/usb/usx2y/usbusx2y.c > > +++ b/sound/usb/usx2y/usbusx2y.c > > @@ -244,6 +244,9 @@ static void i_usX2Y_In04Int(struct urb *urb) > > > > usb_sndbulkpipe(usX2Y->dev, 0x04), &p4out->val.vol, > > p4out->type > > == eLT_Light ? sizeof(struct us428_lights) : 5, > > > > i_usX2Y_Out04Int, usX2Y); > > + err = > > usb_urb_ep_type_check(usX2Y->AS04.urb[j]); > > + if (err < 0) > > + break; > > It doesn't make much sense to add this check to the completion handler, > where, if you ever get here, you already know that endpoint check at > first submission succeeded.
OK, this one can be dropped while the latter one is kept. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
