On Mon, Dec 11, 2017 at 5:45 PM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > Romain Izard reported the following about commit 7a9618a22aad: > > As it reached Linus' tree with v4.15-rc3, I recently noticed the > following commit that triggered a Kconfig request. I believe that this > change does not make sense. > > 7a9618a22aa usb: gadget: allow to enable legacy drivers without USB_ETH > > USB_ETH was not a dependency, but a default value for the choice. As the > choice was marked as "optional", it was possible to remove this value > when building. > > After this modification, the Kconfig choice option does not contain > anything anymore, so it is useless. It is also possible to select > multiple built-in legacy drivers. This builds, but will not work as > expected as only one legacy driver can be bound to an USB device > controller at a time. > > Hence revert commit 7a9618a22aad. > > Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com> > Cc: Romain Izard <romain.izard....@gmail.com> > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Stephen Rothwell <s...@canb.auug.org.au> > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > Cc: Hannes Reinecke <h...@suse.com> > Cc: Nicholas Bellinger <n...@linux-iscsi.org> > Cc: Andrzej Pietrasiewicz <andrze...@samsung.com> > Cc: linux-usb@vger.kernel.org > Cc: Felipe Balbi <felipe.ba...@linux.intel.com>
Ok, let's use this one instead of my patch then, Acked-by: Arnd Bergmann <a...@arndb.de> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
