On Wed, Jan 03, 2018 at 03:04:19PM -0600, Pete Zaitcev wrote: > @@ -1231,12 +1233,15 @@ static int mon_bin_vma_fault(struct vm_fault *vmf) > unsigned long offset, chunk_idx; > struct page *pageptr; > > + mutex_lock(&rp->fetch_lock); > offset = vmf->pgoff << PAGE_SHIFT; > if (offset >= rp->b_size) > + mutex_unlock(&rp->fetch_lock); > return VM_FAULT_SIGBUS; > chunk_idx = offset / CHUNK_SIZE;
missing braces ... maybe you'd rather a 'goto sigbus' approach? > pageptr = rp->b_vec[chunk_idx].pg; > get_page(pageptr); > + mutex_unlock(&rp->fetch_lock); > vmf->page = pageptr; > return 0; > } > > -- Pete > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"d...@kvack.org";> em...@kvack.org </a> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
