On Monday 07 May 2007, Andreas Volz wrote:
> Am Mon, 7 May 2007 15:32:58 +0200 schrieb Laurent Pinchart:
> > On Monday 07 May 2007, Laurent Pinchart wrote:
> > > On Monday 07 May 2007, Andreas Volz wrote:
> > > > Am Sun, 6 May 2007 22:10:25 +0200 schrieb Laurent Pinchart:
> >
> > [snip]
> >
> > > > > There is no point in testing dv mode, only webcam mode will
> > > > > work for now. We will try dv mode after being done with webcam
> > > > > mode.
> >
> > Now that webcam mode somehow works, could you test the following
> > patch with DV mode ? The driver should detect and initialise the
> > camera, but luvcview will probably not work. Please post the kernel
> > log (at trace=255) after plugging the device.
>
> I applied the patch. I tried it with trace=255 and trace=65535. Here is
> the result:
>
> http://tux-style.de/tmp/dmesg2.txt

My bad, I forgot part of the patch :-/ Could you please try again with this 
one ? Thanks.

Best regards,

Laurent Pinchart
Index: uvc_driver.c
===================================================================
--- uvc_driver.c	(revision 103)
+++ uvc_driver.c	(working copy)
@@ -319,8 +319,40 @@
 		ftype = VS_FRAME_MJPEG;
 		break;
 
+	case VS_FORMAT_DV:
+		if (buflen < 9) {
+			uvc_trace(UVC_TRACE_DESCR, "device %d videostreaming"
+			       "interface %d FORMAT error\n",
+			       dev->udev->devnum,
+			       alts->desc.bInterfaceNumber);
+			return -EINVAL;
+		}
+
+		switch (buffer[8]) {
+		case 0:
+			strncpy(format->name, "SD-DV", sizeof format->name);
+			break;
+		case 1:
+			strncpy(format->name, "SDL-DV", sizeof format->name);
+			break;
+		case 2:
+			strncpy(format->name, "HD-DV", sizeof format->name);
+			break;
+		default:
+			uvc_trace(UVC_TRACE_DESCR, "device %d videostreaming"
+			       "interface %d: unknown DV format %u\n",
+			       dev->udev->devnum,
+			       alts->desc.bInterfaceNumber, buffer[8]);
+			return -EINVAL;
+		}
+
+		format->fcc = V4L2_PIX_FMT_DV;
+		format->flags = V4L2_FMT_FLAG_COMPRESSED;
+		format->bpp = 0;
+		ftype = 0;
+		break;
+
 	case VS_FORMAT_MPEG2TS:
-	case VS_FORMAT_DV:
 	case VS_FORMAT_FRAME_BASED:
 	case VS_FORMAT_STREAM_BASED:
 		/* Not supported yet. */
@@ -522,11 +554,11 @@
 		switch (_buffer[2]) {
 		case VS_FORMAT_UNCOMPRESSED:
 		case VS_FORMAT_MJPEG:
+		case VS_FORMAT_DV:
 			nformats++;
 			break;
 
 		case VS_FORMAT_MPEG2TS:
-		case VS_FORMAT_DV:
 		case VS_FORMAT_FRAME_BASED:
 		case VS_FORMAT_STREAM_BASED:
 			uvc_trace(UVC_TRACE_DESCR, "device %d videostreaming "
_______________________________________________
Linux-uvc-devel mailing list
Linux-uvc-devel@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel

Reply via email to