Hi Ivan, On Sunday 04 November 2007, Ivan N. Zlatev wrote: > Hello, > > Attached you will find a patch that adds iSight support to uvcvideo > and applies to HEAD (revision 140). This patch has existed for some > time now. Initially it was very instrusive to the uvcvideo code, but > this has been fixed.
I can see that, it got better :-) > Please, lets get this reviewed and merged with uvcvideo. It's very > time consuming for me to keep it in sync with uvcvideo head. openSUSE > patches uvcvideo with this patch, Gentoo too, possibly others. It > would make our life much easier if we could get this upstream. Ok, let's try. I agree keeping patches in sync isn't exactly fun. > This patch enables the isight camera found in all apple macs fully, > including suspend and resume support. > > iSight is an uvc device, but not fully. I am not an expert but it > seems to use a custom packet format on top of the uvc, has different > guid, has partially broken video descriptors and requires firmware. > This patch deals with those in the most intrusive way I could. I suppose you mean the less intrusive way. > Inside the uvcvideo code it will only change the decoding queue if the > device is recognized as an isight device. In addition it will call > uvc_load_firmware during the uvc initialization. > > Outside in the self-contained isight.c|h it will handle the firmware > loading, patching the usb descriptors and the decoding. > > I would like to express my gratitude to Martin Szulecki who worked > with me on getting the patch in sync with latest uvcvideo and testing > it for the past two days. There are two issues left that bother me. 1. I'm still not convinced firmware loading belongs in the kernel. Let's discuss the second issue first. 2. If I'm not mistaken, some iSight firmware revisions set the bInterfaceClass and bInterfaceSubClass fields to 0xff. This won't be compatible with various tests in uvc_driver.c that check for SC_VIDEOSTREAMING or SC_VIDEOCONTROL in the bInterfaceSubClass field. Are you aware of the second problem ? Best regards, Laurent Pinchart _______________________________________________ Linux-uvc-devel mailing list Linux-uvc-devel@lists.berlios.de https://lists.berlios.de/mailman/listinfo/linux-uvc-devel
