Hi Sven,
On Thursday 29 October 2009 19:02:50 Sven Geggus wrote:
> Laurent Pinchart schrieb am Mittwoch, den 28. Oktober um 13:44 Uhr:
> > Could you please try the following patch ? It disables the quirk for
> > compressed formats.
>
> This patch does not apply here (Vanilla Kernel Linux 2.6.31.5).
>
> I suppose this would be equivalent:
>
> diff --git a/drivers/media/video/uvc/uvc_video.c
> b/drivers/media/video/uvc/uvc_video.c
> index 01b633c..df8a335 100644
> --- a/drivers/media/video/uvc/uvc_video.c
> +++ b/drivers/media/video/uvc/uvc_video.c
> @@ -90,7 +90,8 @@ static void uvc_fixup_video_ctrl(struct uvc_video_device
> *video,
> ctrl->dwMaxVideoFrameSize =
> frame->dwMaxVideoFrameBufferSize;
>
> - if (video->dev->quirks & UVC_QUIRK_FIX_BANDWIDTH &&
> + if (!(format->flags & UVC_FMT_FLAG_COMPRESSED) &&
> + video->dev->quirks & UVC_QUIRK_FIX_BANDWIDTH &&
> video->streaming->intf->num_altsetting > 1) {
> u32 interval;
> u32 bandwidth;
Yes it is.
> The above change _does_ make it work the same as getting rid of the quirks
> altogether. There might be different firmware Version of the devices
> around.
Thanks. I'll apply the patch then.
> BTW wouldn't it be better to make the quirks module parameter _overwrite_
> camera specific quirks altogether instead of adding them with xor? This way
> I would have been able to disable the quirks without patching the module.
It could be useful, but quirks activated by mistake (or not doing their job
properly) shouldn't occur often as those problems result of a driver bug. I
don't think there's really a need for this.
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-uvc-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel
