Hello Guenter,
On Sun, Nov 22, 2015 at 07:20:59PM -0800, Guenter Roeck wrote:
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index b535b02b1d7f..f0292d56caf0 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -108,6 +108,7 @@ struct watchdog_device {
> #define WDOG_ALLOW_RELEASE 2 /* Did we receive the magic char ? */
> #define WDOG_NO_WAY_OUT 3 /* Is 'nowayout' feature set ?
> */
> #define WDOG_UNREGISTERED 4 /* Has the device been unregistered */
> +#define WDOG_RUNNING 5 /* True if HW watchdog running */
> /* the following variables are for internal use only */
> struct mutex lock;
> unsigned long last_keepalive;
> @@ -124,6 +125,12 @@ static inline bool watchdog_active(struct
> watchdog_device *wdd)
> return test_bit(WDOG_ACTIVE, &wdd->status);
> }
>
> +/* Use the following function to check whether or not the watchdog is
> running */
I'd like to have this comment more clear to distinguish between device
state and userspace view. Maybe also call the flag WDOG_HW_RUNNING to
make this more clear?
> +static inline bool watchdog_running(struct watchdog_device *wdd)
> +{
> + return test_bit(WDOG_RUNNING, &wdd->status);
> +}
> +
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
