Hi Uwe, > omap_wdt_start calls pm_runtime_get_sync so dropping a reference just > before calling omap_wdt_start doesn't make much sense. Moreover there is > no point to use the synchronous variant of pm_runtime_put because the > driver doesn't care if the clock is disabled before or after > omap_wdt_probe returns. > > Signed-off-by: Uwe Kleine-König <[email protected]> > --- > drivers/watchdog/omap_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c > index 7abd6988d94a..af8947429c91 100644 > --- a/drivers/watchdog/omap_wdt.c > +++ b/drivers/watchdog/omap_wdt.c > @@ -282,11 +282,11 @@ static int omap_wdt_probe(struct platform_device *pdev) > readl_relaxed(wdev->base + OMAP_WATCHDOG_REV) & 0xFF, > wdev->wdog.timeout); > > - pm_runtime_put_sync(wdev->dev); > - > if (early_enable) > omap_wdt_start(&wdev->wdog); > > + pm_runtime_put(wdev->dev); > + > return 0; > } >
Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
