Sujith Manoharan wrote: > I don't think trying to switch channel contexts in the flush() callback > is a good idea. We would be changing the meaning of the callback if > we do that. Moreover flush() is called from many other places too, like the > PS code. > > It seems appropriate to instruct a driver to make the necessary > preparations before sending a deauth frame. Do you see any problems > if mgd_prepare_tx() is called before initiating deauth ?
Calling mgd_prepare_tx() in ieee80211_send_deauth_disassoc(), which was the case originally, is probably more correct, since there are other situations where this will be a problem. CSA is one example. The driver can receive a beacon, mac80211 begins to process the CSA and if multiple contexts are active, initiates a disconnect operation. But, in the meantime, if the driver has switched to a different context, things will break. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
