On Sun, 2015-02-08 at 15:52 +0200, Dedy Lansky wrote: > @@ -961,6 +961,12 @@ int cfg80211_connect(struct cfg80211_registered_device > *rdev, > memcpy(wdev->ssid, connect->ssid, connect->ssid_len); > wdev->ssid_len = connect->ssid_len; > > + wdev->conn_bss_type = IEEE80211_BSS_TYPE_ESS; > + if (connect->channel && > + connect->channel->band == IEEE80211_BAND_60GHZ && > + wdev->iftype == NL80211_IFTYPE_P2P_CLIENT) > + wdev->conn_bss_type = IEEE80211_BSS_TYPE_PBSS;
This looks wrong, what if the driver did channel selection? Then all of this breaks. Perhaps it'd be better to punt this to drivers by introducing cfg80211_connect_result_bss() along with the existing cfg80211_roamed_bss(), so drivers can just look up and pass the correct BSS entry. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
