>>>> diff --git a/drivers/net/wireless/ath/ath10k/hw.h >>>> b/drivers/net/wireless/ath/ath10k/hw.h >>>> index 85cca29..37fd2f83 100644 >>>> --- a/drivers/net/wireless/ath/ath10k/hw.h >>>> +++ b/drivers/net/wireless/ath/ath10k/hw.h >>>> @@ -296,7 +296,7 @@ enum ath10k_hw_rate_cck { >>>> #define TARGET_10X_RX_SKIP_DEFRAG_TIMEOUT_DUP_DETECTION_CHECK 1 >>>> #define TARGET_10X_VOW_CONFIG 0 >>>> #define TARGET_10X_NUM_MSDU_DESC (1024 + 400) >>>> -#define TARGET_10X_MAX_FRAG_ENTRIES 0 >>>> +#define TARGET_10X_MAX_FRAG_ENTRIES 10 >>> >>> This is probably enough at "2" (ath10k doesn't send more than 2 tx >>> fragments now). I assume fw crashes with raw tx if this isn't fixed, >>> correct? >>> >>> Sidenote: I guess TARGET_MAX_FRAG_ENTRIES could be fixed as well. It >>> might make sense for QCA61X4 hw2.1 which still uses the old Rx >>> indication event and might be able to do raw txrx + swcrypto. But I'm >>> a bit reluctant to change this without any testing. >>> >> >> Sure. I change it to 10 because the document I got from QCA says so. >> Since this is a global setting, I will remove this and keep it =0 for >> now so it doesn't affect existing HW based datapath. > > Sure. I recall 10.x on QCA988X isn't really picky on this value. > QCA61X4 with wmi-tlv on the other hand needs an adequate value for > this configuration parameter or it'll crash horribly. > > >> Per QCA, the main issue not changing this would be SW crypto then >> won't be able to handle large Rx AMSDU. >> When HW is not doing Rx decryption, the whole AMSDU needs to be DMA to >> host for SW based decryption & AMSDU subframe deaggregation. > > Hmm.. From what I know this setting refers to the max number of Tx > fragments that can be submitted via HTT TX_FRM command eventually to > HW MAC, not Rx fragments. >
Yeah you are right. I checked the QCA's PDF again and indeed it's for Tx not for Rx. David > > MichaĆ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html