Hello David.

Thanks for your detail review.
The code is wrong and will be removed because of unused code later.

Regards.
Johnny.

-----Original Message-----
From: David Binderman [mailto:dcb...@hotmail.com] 
Sent: Tuesday, July 07, 2015 8:19 PM
To: Kim, Johnny; Kim, Rachel; Lee, Dean; Park, Chris; 
linux-wireless@vger.kernel.org
Subject: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?

Hello there,

[linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer 
can not be negative so it is either pointless or an error to check if it is.

Source code is

     if (wilc_mac_thread < 0) {

but

struct task_struct *wilc_mac_thread;

Regards

David Binderman

                                          
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to