David Lin <d...@marvell.com> writes: > The Linux driver for WRT1900AC. The work was initially developed as part of > openwrt effort and maintained on https://github.com/kaloz/mwlwifi. > > This is still work in progress, with 8864 chipset more mature and tested, > while 8897 for the similar use case is added recently. > > Signed-off-by: David Lin <d...@marvell.com>
The commit log is really short. For a new driver you should explain a lot more, for example what works and what doesn't. Also it should contained detailed info about how and why (!) this conflicts with mwifiex and the way that problem was solved. Also no new BUG_ON() calls in drivers, please: fwcmd.c: BUG_ON(tid >= SYSADPT_MAX_TID); mac80211.c: BUG_ON(queue > SYSADPT_TX_WMM_QUEUES - 1); mac80211.c: BUG_ON(stream->state != AMPDU_STREAM_IN_PROGRESS); tx.c: BUG_ON(tid > 7); tx.c: BUG_ON(tid >= SYSADPT_MAX_TID); tx.c: BUG_ON(!tx_skb); We should start to get rid of all 200+ calls we already have, wireless drivers should never call BUG_ON(). Instead use descriptive error message (WARN_ON() etc) and bail out nicely with an error. That's much more user friendly than crashing the kernel. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
