> On November 26, 2015 5:40 PM, Johannes Berg wrote: > > On Thu, 2015-11-26 at 08:27 +0000, David Lin wrote: > > > > Since you do this in .probe, you should consider loading the > > > firmware asynchronously. > > > > > > > I hope I can postpone this modification later. > > I don't feel strongly about this one - otoh it's not really complicated. >
Thanks. > > > > +#ifdef CONFIG_SUPPORT_MFG > > > > > > This Kconfig variable doesn't exist. > > > > > > > The compile variable is used privately by Marvell and our customers in > > production line. > > Yeah, still. Make it a proper Kconfig variable, defaulting to off and hidden > under something, or remove it. It's extremely misleading to have something > called CONFIG_* when it's not a Kconfig variable. > I will change this compile variable from "CONFIG_SUPPORT_MFG" to "SUPPORT_MFG". > > Mac80211 does not support mesh AMSDU now, we implement this function > > in mwlwifi driver for the time being. Except for mesh AMSDU, we still > > leverage mac80211 to handle data AMSDU. > > You're allowed to modify mac80211. > > > > What's going on here? Why are you modifying the action frames on the > > > fly??! > > > > > > > Due to mwlwifi supports Tx/Rx AMSDU, these frames are modified to > > inform client that we support AMSDU. > > > > Ditto - you're allowed to modify mac80211. We actually have a patch like this > already: > https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211- > next.git/commit/?id=99e7ca44bb910f0cbfda5d9008e8517df0ebc939 > Once if this patch is ready, I will modify mwlwifi to use it. Thanks. > johannes > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the > body of a message to majord...@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html
