> From: Johannes Berg [mailto:johan...@sipsolutions.net] > Sent: Monday, December 14, 2015 5:53 PM > To: Amitkumar Karwar; linux-wireless@vger.kernel.org > Cc: Cathy Luo; Nishant Sarmukadam > Subject: Re: [PATCH 00/14] mwifiex fixes > > On Mon, 2015-12-14 at 04:15 -0800, Amitkumar Karwar wrote: > > These patches include few fixes for mwifiex and add a debugfs file for > > chip reset. > > > > A lot of these "fixes" look like new firmware features to me (e.g. > interface limits, sms4 cipher, pattern length).
These features are supported even with older firmwares. It’s just that they are advertised now to meet specific requirements from customer. sms4 cipher - WAPI is supported in firmware for long time. interface limits - Interface limit has been changed, but total number of maximum interfaces are same. Change is compatible with older firmware. pattern length - User provided pattern length (wildcard bytes + actual bytes) has been increased to accommodate more wildcard bytes. No change in actual packet length supported by firmware. > > First of all - is that really appropriate as "fixes", what tree are you > targeting? Most of the patches in this series are fixes. Hence I used word 'fixes'. I am targeting them for wireless-drivers-next tree only. > > And secondly, how are you making sure the user won't have an older > firmware version where this will presumably cause crashes? > This patch series doesn’t include any new feature which aren't supported by older firmware. Regards, Amitkumar N�����r��y����b�X��ǧv�^�){.n�+����{��*ޕ�,�{ay�ʇڙ�,j��f���h���z��w��� ���j:+v���w�j�m��������zZ+�����ݢj"��!�i