On Wed, Dec 16, 2015 at 03:15:40PM +0100, Johannes Berg wrote: > On Wed, 2015-12-16 at 06:11 -0800, Ben Greear wrote: > > > My code expected that the key was the MAC of the radio, not the > > MAC of a vif. It set up mappings accordingly in the user-space > > program. > > I guess you were trying to be much smarter than wmediumd :) > > Bob, any thoughts?
So, now that I understand the argument, I see the value in having an unchanging key for each phy. I'm also pretty sure that it was by accident that it used to work that way. If we were designing the ABI from scratch, radio id would probably be better than a mac address for that purpose. Anyway, in the interest of not breaking userspace, I'm not opposed to reverting that patch, and perhaps adding some documentation on top to make it clear that the addr attributes have nothing to do with any mac addresses actually in use. For wmediumd users that would mean going back to the way it was previously, in which only the 42:xx mac addresses will work, until I can work out another way to do it. I think that would break the test_wmediumd.py in hostapd test suite in the meantime though. -- Bob Copeland %% http://bobcopeland.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
