On Tue, Feb 23, 2016 at 5:14 AM, Johannes Berg <johan...@sipsolutions.net> wrote: > On Tue, 2016-02-16 at 16:28 -0500, Avery Pennarun wrote: >> Since around the beginning of time, ath9k aggregates have timed out >> after >> 5000 TU (around 5000ms) of inactivity, but nobody seems to be quite >> sure >> why, and this magic number seems to have migrated around from one >> place to >> another. An openbsd mailing list recently had a patch to disable the >> timeout completely, which they say matches some commercial routers: >> https://www.mail-archive.com/tech@openbsd.org/msg29456.html >> >> Even in Linux, several non-ath9k drivers default to no timeout >> already. I >> think changing it directly to zero would be safe, but to allow a more >> structured investigation, let's make it configurable for now. >> > Since we just made it zero, perhaps we don't need this? > > Although perhaps we still want it to be able to debug it?
We're putting my version of the patch into our devices in order to be able to try different values and see how it changes the percentage of devices with nonzero 'pending' field in agg_status. I'm hoping using zero here will result in total elimination of the pending problem, but we'll see. It probably makes sense not to apply this upstream if the default value is zero now anyway. > Anyway - you shouldn't create a debugfs file and play with the extern > stuff etc., let minstrel create the debugfs file in minstrel_ht_alloc() Good point. I had a feeling I was doing that in the wrong place :) If people think this is important, I can respin the patch, otherwise feel free to discard. Have fun, Avery -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
