jes.soren...@redhat.com writes: > From: Jes Sorensen <jes.soren...@redhat.com> > > The 8723bu also has it's own IQK calibration process. This is similar > in flow, but still different enough to warrent it's own > implementation, at least for now. > > Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 811 > ++++++++++++++++++++- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 + > .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 17 + > 3 files changed, 827 insertions(+), 2 deletions(-) >
[...] > +#ifdef RTL8723BU_BT > + /* GNT_BT = 1 */ > + rtl8xxxu_write32(priv, REG_BT_CONTROL_8723BU, 0x00001800); > +#endif What's this about? > +#ifdef RTL8723BU_BT > + /* GNT_BT = 1 */ > + rtl8xxxu_write32(priv, REG_BT_CONTROL_8723BU, 0x00001800); > +#endif Same here. > +#ifdef RTL8723BU_PATH_B > +static int rtl8723bu_iqk_path_b(struct rtl8xxxu_priv *priv) And this? > +#if 0 > + /* Page B init */ > + rtl8xxxu_write32(priv, REG_CONFIG_ANT_A, 0x0f600000); > + > + if (priv->tx_paths > 1) > + rtl8xxxu_write32(priv, REG_CONFIG_ANT_B, 0x0f600000); > +#endif Like discussed before, "#if 0" is not really welcomed in upstream. Can't you just keep the unimplemented parts in a private branch and submit them once they are ready? That way upstream code is not cluttered with these. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
