On 10 March 2016 at 19:57, Dave Taht <dave.t...@gmail.com> wrote:
>>> regular fq_codel uses 1024 and there has not been much reason to
>>> change it. In the case of an AP which has more limited memory, 256 or
>>> 1024 would be a good setting, per station. I'd stick to 1024 for now.
>>
>> Do note that the 4096 is shared _across_ station-tid queues. It is not
>> per-station. If you have 10 stations you still have 4096 flows
>> (actually 4096 + 16*10, because each tid - and there are 16 - has it's
>> own fallback flow in case of hash collision on the global flowmap to
>> maintain per-sta-tid queuing).
>
> I have to admit I didn't parse this well - still haven't, I think I
> need to draw. (got a picture?)
No picture, sorry. Let me rehash instead:
- there's a pool of 4096 tubes (flows),
- tubes in the pool are empty,
- each tube has an id sticker (0,1,2,3,...),
- each wi-fi station has 16 boxes (tids) for tubes as well,
- each station box has 1 extra immovable tube (flow),
- packets are hashed into tube id stickers,
- matching tube can be:
- in the pool;
- move the tube into station-box the packet is associated with
- put the packet into tube
- in the station-box the packet is associated with
- just put the packet into tube
- in a station-box different from the one the packet is associated with
- (this is the collision case for fallback flow)
- put the packet into the immovable tube of station box the
packet is associated with
- whenever a tube becomes empty it is moved back to the pool
> Where is this part happening in the code (or firmware?)
It's in the ieee80211_txq_enqueue(). My patch originally contains a
mistake (pointed out by Felix) and the function should actually look
like this:
> static void ieee80211_txq_enqueue(struct ieee80211_local *local,
> struct txq_info *txqi,
> struct sk_buff *skb)
> {
> struct ieee80211_fq *fq = &local->fq;
> struct ieee80211_hw *hw = &local->hw;
> struct txq_flow *flow;
> struct txq_flow *i;
> size_t idx = fq_hash(fq, skb);
>
> flow = &fq->flows[idx];
>
> if (flow->txqi && flow->txqi != txqi)
> flow = &txqi->flow;
[...]
> I assembled a few of the patches to date (your fq_codel patch, avery's
> and tims ath9k stuff) and tested them, to no measurable effect,
> against linus's tree a day or two back. I also acquired an ath10k card
> - would one of these suit?
>
> http://www.amazon.com/gp/product/B011SIMFR8?psc=1&redirect=true&ref_=oh_aui_detailpage_o08_s00
I haven't used this particular card. It's an older chip (no MU-MIMO)
but otherwise should work fine.
Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
