On Fri, Mar 18, 2016 at 01:29:11PM +1100, Julian Calaby wrote: > In some of the non-success return paths, the memory allocated by > iwl4965_sta_alloc_lq() in iwl4965_alloc_bcast_station() is not freed. > > In particular: > - if the card isn't ready after il4965_prepare_card_hw() > - if the card is hardware-rfkilled > > In the hardware rfkilled path, the driver enables the rfkill > interrupt. When the card is unrfkilled and this interrupt is raised > we end up calling il4965_bg_restart() which calls __il4965_up() which > calls iwl4965_alloc_bcast_station() again. > > Suggested-by: Jia-Ju Bai <baijiaju1...@163.com> > Signed-off-by: Julian Calaby <julian.cal...@gmail.com> > > --- > > This is only compile tested as I don't have compatible hardware. I also > don't know the driver enough to know that this is truly correct - however > it looks right and I stand by my analysis. > > Could someone else please review this?
I have similar objection like on previous patch "iwl4965: Fix a memory leak in error handling code of __il4965_up" . Next week I will try test that on the HW and see how it's going. For now this look for me, like different fix should be prepared. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
