On 10 May 2016 at 01:10, <gree...@candelatech.com> wrote: > From: Ben Greear <gree...@candelatech.com> > > Might want to turn off verbose debug as soon as you > see a firmware crash, for instance. Helps keep dmesg > output from over-running the stuff you care about. > > Signed-off-by: Ben Greear <gree...@candelatech.com> > --- > drivers/net/wireless/ath/ath10k/debug.c | 5 +++++ > drivers/net/wireless/ath/ath10k/debug.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath10k/debug.c > b/drivers/net/wireless/ath/ath10k/debug.c > index e251155..a689bf1 100644 > --- a/drivers/net/wireless/ath/ath10k/debug.c > +++ b/drivers/net/wireless/ath/ath10k/debug.c > @@ -194,6 +194,11 @@ void ath10k_print_driver_info(struct ath10k *ar) > } > EXPORT_SYMBOL(ath10k_print_driver_info); > > +void ath10k_set_debug_mask(unsigned int v) {
The { should be on new line. > + ath10k_debug_mask = v; > +} > +EXPORT_SYMBOL(ath10k_set_debug_mask); I didn't see any uses of this in your patchset (it's commented out in 21/21) and I'm not fully convinced it's a good idea to override debug_mask like that. Once I set a debug_mask I expect it to stay unchanged. What if I do want to trace what happens after fw crash? Wouldn't it be better to have a knob to tell ath10k whether hw recovery should be automatic or manual? MichaĆ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html