On 06/27/2016 10:55 PM, Joe Perches wrote:
On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote:
On 06/25/2016 05:46 PM, Joe Perches wrote:
This debugging macro can expand to a lot of code.
Make it a function to reduce code size.
(x86-64 defconfig w/ all rtlwifi drivers and allyesconfig)
$ size drivers/net/wireless/realtek/rtlwifi/built-in.o*
text data bss dec hex filename
900083 200499 1907 1102489 10d299
drivers/net/wireless/realtek/rtlwifi/built-in.o.defconfig.new
1113597 200499 1907 1316003 1414a3
drivers/net/wireless/realtek/rtlwifi/built-in.o.defconfig.old
1746879 453503 8512 2208894 21b47e
drivers/net/wireless/realtek/rtlwifi/built-in.o.new
2051965 503311 8512 2563788 271ecc
drivers/net/wireless/realtek/rtlwifi/built-in.o.old
Signed-off-by: Joe Perches <j...@perches.com>
I acked this before; however there is a bug that breaks the build if
CONFIG_RTLWIFI_DEBUG is not defined. The rest of the code calls
_rtl_dbg_trace(), but that symbol is never defined. The problem can be fixed in
debug.c or debug.h.
Confused a bit. What breaks again?
Nothing breaks and your patch is OK. I had ported it to a GitHub repo of these
drivers, which had a different debug.h. That led to the missing global when
CONFIG_RTLWIFI_DEBUG was not defined. That has now been fixed.
Sorry for the confusion.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
