On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: > On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: > > From: Daniel Wagner <daniel.wag...@bmw-carit.de> > > [..] > > Do not quite like it... I'd rather asynchronous request give out a > firmware status pointer that could be used later on. > > pcu->fw_st = request_firmware_async(IMS_PCU_FIRMWARE_NAME, > pcu, > ims_pcu_process_async_firmware); > if (IS_ERR(pcu->fw_st)) > return PTR_ERR(pcu->fw_st); > > .... > > fw_loading_wait(pcu->fw_st); >
In the remoteproc case (patch 6) this would clean up the code, rather than replacing the completion API 1 to 1. I like it! Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
